求救，这个我瞎写的脚本有办法缩短吗

yang1zhi

太可怕了。状态少的时候还好。状态多起来要给每种排列都设定。


[pre lang="ruby" line="1"]def slip_damage_effect
  xxxx = self.maxhp / 30
  yyyy = self.hp / 20
  zzzz = self.maxsp / 20
  qqqq = self.maxhp / 10
  if self.state?(24) and self.state?(3) and self.state?(32)  and self.state?(45)  
    #默认的回血毒烧伤回SP效果
    self.damage["slip"] = (xxxx + yyyy - qqqq)
    self.damage_sp["slip"] = zzzz
    self.hp -= self.damage["slip"]
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(24) and self.state?(3) and self.state?(32)#默认的毒烧伤回血效果
    self.damage["slip"] = (xxxx + yyyy - qqqq)  
    self.hp -= self.damage["slip"]
    return true
  end
  if self.state?(3) and self.state?(32)#默认的毒烧伤效果
    self.damage["slip"] = (xxxx + yyyy)  
    self.hp -= self.damage["slip"]
    return true
  end
  if  self.state?(24) and self.state?(32)  and self.state?(45)  #默认的烧伤回SP回血效果
    self.damage["slip"] = (yyyy - qqqq)
    self.damage_sp["slip"] = zzzz
    self.hp -= self.damage["slip"]
    self.sp += self.damage_sp["slip"]
    return true
  if  self.state?(32)  and self.state?(45)  #默认的烧伤回SP效果
    self.damage["slip"] = yyyy
    self.damage_sp["slip"] = zzzz
    self.hp -= self.damage["slip"]
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(24) and self.state?(3) and self.state?(45)  #默认的毒回SP回血效果
    self.damage["slip"] = (xxxx - qqqq)
    self.damage_sp["slip"] = zzzz
    self.hp -= self.damage["slip"]
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(3) and self.state?(45)  #默认的毒回SP效果
    self.damage["slip"] = xxxx
    self.damage_sp["slip"] = zzzz
    self.hp -= self.damage["slip"]
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(24) and self.state?(3) #默认的毒回血效果
    self.damage["slip"] = (xxxx - qqqq)
    self.hp -= self.damage["slip"]
    return true
  end
  if self.state?(3) #默认的毒效果
    self.damage["slip"] = xxxx
    self.hp -= self.damage["slip"]
    return true
  end
  if self.state?(24) and self.state?(32) #烧伤回血
    self.damage["slip"] = (yyyy - qqqq)
    self.hp -= self.damage["slip"]
    return true
  end
  if self.state?(32) #烧伤
    self.damage["slip"] = yyyy
    self.hp -= self.damage["slip"]
    return true
  end
  if self.state?(24) and self.state?(45)  #回SP回血效果
    self.damage["slip"] = qqqq
    self.hp += self.damage["slip"]
    self.damage_sp["slip"] = zzzz
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(45)  #回SP效果
    self.damage_sp["slip"] = zzzz
    self.sp += self.damage_sp["slip"]
    return true
  end
  if self.state?(24)  #回血
    self.damage["slip"] = qqqq  
    self.hp += self.damage["slip"]
    return true
  end
  # 过程结束
  return true
end
end[/pre]

yang1zhi

最后添加得太多了报错了{:2_264:}

RyanBern

4个状态共要考虑16种情况……
self.damage被黑掉了？
即兴写下面的脚本，未测试
[pre lang="Ruby"]# 3=>毒
# 24=>回血
# 32=>烧伤
# 45=>回蓝
def slip_damage_effect
  hp_v = {3 => self.maxhp / 30, 24 => -self.hp / 20, 32 => self.maxhp / 10}
  sp_v = {45 => -self.maxsp / 20}
  hp_damage = 0
  sp_damage = 0
  hp_v.keys.each do |id|
    hp_damage += hp_v[id] if self.state?(id)
  end
  sp_v.keys.each do |id|
    sp_damage += sp_v[id] if self.state?(id)
  end
  self.damage["slip"] = hp_damage if hp_damage != 0
  self.hp -= hp_damage
  self.damage_sp["slip"] = sp_damage if sp_damage != 0
  self.sp -= sp_damage
end[/pre]

chd114

你这是用在哪里的脚本···